c3c icon indicating copy to clipboard operation
c3c copied to clipboard

AST JSON: Constants are not present

Open Caleb-o opened this issue 1 year ago • 2 comments

Constants seem to not be emitted into the JSON at all, when they should be.

Caleb-o avatar Oct 10 '24 00:10 Caleb-o

Hi, new here. I was trying to solve this issue and I also added the type to the globals as well. I will try to add also the init value. Is it ok if I collapse the two issues in only one? By the way this is my first contribution ever, there are any instructions on how to contribute to this project beside the code of conduct and the codestyle files?

cardisk avatar Oct 11 '24 19:10 cardisk

Not really, just rebase the commit so that it's a single commit. And add a line in the release notes for the change.

lerno avatar Oct 12 '24 01:10 lerno

Is this fixed?

lerno avatar Nov 14 '24 00:11 lerno

Yes. There are a few expressions that I really cannot trigger so I wasn't able to output a specific value for them, instead I outputted a TODO: with the corresponding type so in the future it can be easy to implement them. At the moment there are no TODOs inside the standard library. If this issue can be closed I think also the #1541 one should, because inside the AST constants and globals have the same output.

cardisk avatar Nov 14 '24 10:11 cardisk

Also closing this, as we're reworking what it should contain, see #2349

lerno avatar Oct 10 '25 18:10 lerno