Fix docker build issue in ubuntu kinetic
The official ubuntu image in DockerHub does not contain 22.10 aka Kinetic. This merge request changes the UBUNTU_VERSION to 22.04 aka Jammy.
Changelog:
- Update
UBUNTU_VERSIONto22.04to build on Jammy - Update
LLVM_VERSIONfrom 15 to 17 due to this line inCmakeLists.txt - Add an
UBUNTU_CODENAMEvariable which is used to pull LLVM for a specific Ubuntu version
Thank you. Can we get this into the CI somehow?
I don't use this myself, so I can't judge if we're missing something essential with the removal of 22.10. @Its-Kenta did the previous updates, and so might have a better opinion on how it should work.
Would you like me to add a job to build the project in Ubuntu 22.04? I can start working on an MR right away or wait for more reviews, whichever you prefer.
Getting a CI for it would be awesome.
Something broke in the new ci:
You have an error in your yaml syntax on line 503
Yeah, it was indentation problem. Sorry, about that
On second thought, the CI for Ubuntu 22 already exists in the job build-linux. Wouldn't my addition be redundant?
I wanted the CI to run the docker script. That's what I meant.
There seems to be errors in the CI still.
What is needed to make this work?
It seems we need to add a command to the script to create the build directory where CMakeOutput.log is supposed to be written. The other errors also appear to be caused by the absence of this build directory.
So just a mkdir? Do you know the path?
This is the path expected by Cmake for the CmakeOutput.log:
/home/c3c/source/build/CMakeFiles/CMakeOutput.log
However, the build-with-docker.sh script already has the command mkdir -p build bin which creates these directories.
So what does that mean? That is should work but doesn't?
I suspect the docker container is running as a non-root user, and the script is trying to write to a directory that the user doesn't have write permissions to. I'm adding a potential fix.
Now we seem to be getting:
chown: cannot access 'build': No such file or directory
I am adding the chmod and chown commands directly in the build-with-docker.sh script. This should provide the necessary permissions to write a file inside the build directory.
Ok! Crossing my fingers here :D
Failed again. It must be a permission error because the build and bin directory gets created when I run the script locally.
So, are there still options to try?
#1347 should have merged these changes, if that merge looks good, please close this @MashyBasker
This looks right