Implicit cast from array to vector pointer changes alignment requirement

[cbuttner]

Not a bug, but:

fn void test(float[<4>]* out) {
  *out *= 2;
}

fn int main(String[] args) {
  float[4] v;
  test(&v); // This implicitly changes the alignment requirement of v
}

[lerno]

Yes. I'm not sure whether this is wrong though.

[cbuttner]

This can go completely unnoticed, in fact it almost did for me, especially when the alignment just happens to match up. Then one day it just crashes and you're left wondering why. I'm generally not that worried about footguns, but man, you've got to tighten up some of these implicit conversions. I don't even understand what the benefit of this is, saving a few characters needed to type for an explicit cast?

[lerno]

Indeed. Since the opposite is fine too.

[lerno]

Master is updated.

[lerno]

Please check that it's working correctly for this and other similar pointer conversions.

[lerno]

Is this working?

[cbuttner]

Yes this works well, thank you.