Julian comments

Results 218 comments of


                                            Julian

trafficstars

Compiling on windows adds `#!/usr/bin/env php` to the output

@MacFJA `#!/usr/bin/env php` see my comment above https://github.com/humbug/box/issues/168#issuecomment-385047602 there you have the source and the compiled results for box2 and box3

Compiling on windows adds `#!/usr/bin/env php` to the output

already chatted with @theofidry, i think he knows were the bug is. i think he wrote that the file with the stripped shebang gets overwritten with files imported to the...

Compiling on windows adds `#!/usr/bin/env php` to the output

the bug still exists with version 3.0.0-alpha.4 in the phar file both bin file contain the shebang

Compiling on windows adds `#!/usr/bin/env php` to the output

``` ? Setting replacement values + @git_commit@: 5f620495beb07c9304e4bd88dafa11e45224b1c5 + @git_tag@: 1.0.1 + @git_version@: 1.0.1 ? Registering compactors + KevinGH\Box\Compactor\Json + KevinGH\Box\Compactor\Php ? Adding main file: puppet-enc/bin/puppet-enc ? Adding requirements checker...

Compiling on windows adds `#!/usr/bin/env php` to the output

@theofidry please reopen bug still exist on 3.8.1 and on 3.8.4 verified the php files in `pharfile.phar/bin` all have the sheban line. but now the output is correct `Using shebang...

Compiling on windows adds `#!/usr/bin/env php` to the output

@theofidry the issue is the line. it gets outputed on windows. every phar you create with this line will output this line if run on windows. as the phar should...

Compiling on windows adds `#!/usr/bin/env php` to the output

hm no composer is not doing it. just had a look in `composer.phar/bin/composer` ```

Compiling on windows adds `#!/usr/bin/env php` to the output

yes the problem is that the shebang line is not removed from the php scripts in `bin`/ from the "entry" script in `bin` which is executed when the phar file...

Compiling on windows adds `#!/usr/bin/env php` to the output

both regex patterns (yours and that from composer work on windows) ```

Compiling on windows adds `#!/usr/bin/env php` to the output

just tested the master checkout of box (not the phar file) and the stripping works. `retrieveMainScriptContents` correctly removes the shebang but in the final phar file the shebang is back...