Michael Niewöhner

Results 48 comments of Michael Niewöhner

Ah, I'm sorry. I assumed having a char device... #7 depends on #8 Not sure if the debugfs interface should be kept at all

> The problem might be that you did not really exclude `/test`, because the trailing slash in the exclude-norecurse pattern did not match. Probably yes, but why? From the patterns...

> But that pattern matches things _in_ that directory, so they are excluded. Oh yeah, when reading it like this it indeed makes sense to me! However, Borg still goes...

When the feature is meant to prevent recursion to avoid problems due to bad efficiency, strange effects or weird behaviour with sepcial filesystems, then IMO it's not only cosmetic problem....

> Maybe for borg 2: > > ``` > diff --git a/src/borg/archiver.py b/src/borg/archiver.py > index e3c48ab6..a5aade91 100644 > --- a/src/borg/archiver.py > +++ b/src/borg/archiver.py > @@ -811,6 +811,11 @@ def _rec_walk(self,...

Yeah that was clear, but not the code change :) After staring a while at the code I got it, thank you :+1:

I tested that patch above on 1.2.2. It doesn't seem to work like expected. Debugging shows that matcher.recurse_dir=True and the matcher doesn't match: ``` # borg create --list --pattern='! re:proc/'...

Maybe also add appropriate test cases to the testsuite