sciter-js-sdk icon indicating copy to clipboard operation
sciter-js-sdk copied to clipboard

magick command to make icons does not exist on Ubuntu 20.04 - but I have ImageMagick installed

Open terremoth opened this issue 3 years ago • 8 comments

The "magick" command does not exist, however the "convert" command (used by imagemagick to convert images) exist.

ImageMagick can be easily installed on Ubuntu by simply sudo apt install imagemagick

image

Look what quark setup tries to do:

image

Now you could say "ah this can be solved by just creating an alias in your bashrc like alias magick='convert' right? No, even if I restart the application, does not work either. Seems like a bug, probably easy to correct.

terremoth avatar Mar 25 '22 23:03 terremoth

I solved temporally, I think, (manually) by changing quark/package.js file and changing the "magick" command to "convert" Maybe you could do a variable with a check before if convert command exists and "magick" not, and use convert

However... It seems there is another problem:

image

I am trying, as you see, to generate an app for win64 and linux, and it shows this "winx64 FAILURE, no .dat file" and no Windows file (even the .exe) was generated.

terremoth avatar Mar 26 '22 00:03 terremoth

Actually imagemagik is only used to create the icon for Windows executables. Both Linux and Mac do not have support for icons within the executable.

8ctopus avatar Mar 28 '22 13:03 8ctopus

Actually imagemagik is only used to create the icon for Windows executables. Both Linux and Mac do not have support for icons within the executable.

Of course, but in Ubuntu the Quark and the whole software won't work if this change is not made... The executable will never be generated, this is why this is a bug.

terremoth avatar Mar 29 '22 03:03 terremoth

I guess we can just ignore the whole imagemagik code when not on Windows. @terremoth Maybe you can create a PR?

8ctopus avatar Mar 31 '22 13:03 8ctopus

I think I can do better if I have time: make an "if convert command exists and imagick command does not, use convert command instead", and it will work, but the second problem will remain to create winx64 dat file.

terremoth avatar Mar 31 '22 13:03 terremoth

It would be good to create windows application directly from linux/ubuntus too, so it would need to correctly generate dat file and exe file

terremoth avatar Mar 31 '22 13:03 terremoth

Yes you're right.

8ctopus avatar Apr 01 '22 11:04 8ctopus

I can solve the first problem, but the second one I don't think I can figure out myself

terremoth avatar Apr 01 '22 12:04 terremoth