pyglider icon indicating copy to clipboard operation
pyglider copied to clipboard

polars dependency not being added in a fresh installation

Open richardsc opened this issue 1 year ago • 3 comments

As noted in #188, when I install pyglider fresh, using miniconda on macOS14.5, the polars dependency is not installed, and has to be added manually. I tried on two different macOS machines (intel and arm), with the same result.

richardsc avatar Sep 11 '24 21:09 richardsc

Thanks for raising this Clark! At the moment, the test matrix only tests against ubuntu-latest

https://github.com/c-proof/pyglider/blob/aa43c17c82ae4f53acb41fb3e59e00ef08183f3e/.github/workflows/tests.yml#L9

I'll put in a PR to add mac and windows. Hopefully that will show up the issue, as I don't have a mac here to test with.

callumrollo avatar Oct 07 '24 12:10 callumrollo

It looks like polaras was added to the conda recipe in release 0.07 a couple of weeks ago

https://github.com/conda-forge/pyglider-feedstock/commit/00083d8c63e9d49cb4ad5ee12ae9799d7e53009d

Can you check if that resolves the issue? I'll still work on adding mac and windows to the test matrix to catch these issues earlier in future

callumrollo avatar Oct 07 '24 13:10 callumrollo

Thanks for raising this Clark! At the moment, the test matrix only tests against ubuntu-latest

Just a note that this problem isn't something that can be picked up via CI (as that uses the development environment file). Instead it would require modifying the test: section in the feedstocks recipe.yml. Perhaps adding a simple test case.

VeckoTheGecko avatar Dec 13 '24 13:12 VeckoTheGecko