pwnagotchi-display-password-plugin icon indicating copy to clipboard operation
pwnagotchi-display-password-plugin copied to clipboard

Possible fix for known bug

Open NoxiousKarn opened this issue 1 year ago • 9 comments

https://github.com/c-nagy/pwnagotchi-display-password-plugin/issues/3

By adding:

def init(self): self.peers_detected = False

And: def on_peer_detected(self, agent, peer): self.peers_detected = True

def on_peer_lost(self, agent, peer): self.peers_detected = False

Then modify def on_ui_update to use self.peers_detected as a trigger to hide and unhide the UI element. The plugin should now hide around peers keeping the two UI elements from overlaying each other.

(untested)

NoxiousKarn avatar Sep 07 '23 06:09 NoxiousKarn

Would it be possible to make this plugin overlay all others? exp, gps, etc?

SlitherySnekks avatar Sep 14 '23 04:09 SlitherySnekks

Not code related, but where did you get your pwnagotchi case.

LuchoAba avatar Jan 13 '24 02:01 LuchoAba

Not code related, but where did you get your pwnagotchi case. https://www.thingiverse.com/thing:4551538 @LuchoAba

NoxiousKarn avatar Jan 13 '24 04:01 NoxiousKarn

Not working for me... it always hides the password display.

aerickson avatar Jan 15 '24 04:01 aerickson

aerickson

Sorry man forgot to add a line in def on_peer_lost

corrected now give it a try. let me know if its borked i still have not tested this myself just a concept idea i had one night

NoxiousKarn avatar Jan 15 '24 11:01 NoxiousKarn

Got it working. I think the issue was displaying the element before content had been set.

My changes are at https://github.com/NoxiousKarn/pwnagotchi-display-password-plugin/compare/NoxiousKarn:pwnagotchi-display-password-plugin:master..aerickson:pwnagotchi-display-password-plugin:hide_if_peer_present_with_waveshare_v4

Thanks!

aerickson avatar Jan 16 '24 05:01 aerickson

Ah good ole v4 needed got ya hope the author of the actual plugin adopts the changes. I still have not tested lol glad it went somewhere

On Mon, Jan 15, 2024, 11:01 PM Andrew Erickson @.***> wrote:

Got it working. I think the issue was displaying the element before content had been set.

My changes are at https://github.com/NoxiousKarn/pwnagotchi-display-password-plugin/compare/NoxiousKarn:pwnagotchi-display-password-plugin:master..aerickson:pwnagotchi-display-password-plugin:hide_if_peer_present_with_waveshare_v4

Thanks!

— Reply to this email directly, view it on GitHub https://github.com/c-nagy/pwnagotchi-display-password-plugin/pull/4#issuecomment-1893073426, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4STDX7J6WN3ANWAZV3ZU7LYOYCQZAVCNFSM6AAAAAA4OLJ6KOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJTGA3TGNBSGY . You are receiving this because you authored the thread.Message ID: @.***>

NoxiousKarn avatar Jan 16 '24 07:01 NoxiousKarn

the Method/function ui.hide_element doesnt exist. i cant find it an it isnt working for me :/ Iam on 1.5.5

Solilord avatar Feb 06 '24 21:02 Solilord

Not sure when it was added.

If you're on a rpi zero 2, It definitely works for me on https://github.com/aluminum-ice/pwnagotchi v1.8.4.

aerickson avatar Feb 06 '24 21:02 aerickson