aframe-extras icon indicating copy to clipboard operation
aframe-extras copied to clipboard

startFrame is actually in milliseconds, not in frames

Open kylebakerio opened this issue 3 years ago • 2 comments

makes it tricky to work with assets from my artist. He tells me start at frame 130, using a .5 timescale... that ends up being frame 14000, more or less, figured out by trial and error.

frames should be frames, or the variable should be renamed. and it shouldn't be relative to timescale--or it should be renamed or specified.

kylebakerio avatar Sep 20 '21 03:09 kylebakerio

Can you tell me how did u use the startFrame attribute of the animation-mixer component? The latest CDN link doesn't have the reference for startFrame atrribute. I have a project where I need to jump to a specific time/frame in animation of a gltf model. Any leads will be helpful, TIA.

UrjitDave avatar Nov 04 '21 14:11 UrjitDave

That's correct. You have to actually take it from master directly, not the latest CDN. I literally ended up copy/pasting the JS from the master branch itself and then making the minor tweaks to make it work.

It's not perfect, but it allows using startFrame.

kylebakerio avatar Nov 04 '21 14:11 kylebakerio

Do you want to create a PR to update documentation or adding a comment in the code here @kylebakerio ? Otherwise we can close.

vincentfretin avatar Dec 04 '22 08:12 vincentfretin

(pull request made)

kylebakerio avatar Dec 05 '22 16:12 kylebakerio

Renaming startFrame to startAt in #391

vincentfretin avatar Dec 07 '22 10:12 vincentfretin