Simon Cruanes

Results 408 comments of Simon Cruanes

Ah my bad, what about `wip-merge-pr-5` (which is the rebase of #5)?

Interesting, I don't see a test error on my end. I'd like to merge this at some point but am not confident enough in its correctness. Frankly, help would be...

well, me neither. I think it's different on #5 ?

I think the travis bit is outdated, it should be github actions these days :-)

looking at the doc I came up with this: ```ocaml # let time = Unix.gettimeofday() in Format.printf "%a@." (fun oc f->ISO8601.Permissive.(pp_format oc "%Y/%M/%D at %h:%m:%s" f 0.)) time;; 2020/12/08 at...

Generally speaking, I think the value of this library is in the printers for the ISO8601 format, which are the other named printers. I didn't even pay attention to `pp_format`...

I think there's room for discussion there: - one aspect is compatibility (how much breakage is good for users? breaking a bit might be fine, but if *all* code has...

Could the dates embed the timezone in which they were defined? I'm really no expert but it conveys the intent better and may be more robust in some cases. For...

What breaks on windows? I don't have a windows machine on hand, so help would be appreciated.

> Also, I think that it would be OK, at least for starters, to just fallback dump input on windows. I'm swamped right now (new baby!!) but if you're able...