chef-server
chef-server copied to clipboard
Added parameters and steps to obtain pem files without curl.
Hello!
Foremost, I want to give a thank you for providing this docker image. I was able to setup a quick test chef environment. The setup was pretty straight forward but I wanted to contribute and make the configure script more user-defined.
Changes made to fork: Removed the nginx conf addition that made the admin keys available to anyone who can curl the web server. (for security purposes, in my case I had a public facing server and port 443 was open. Anyone could crawl the chef server and download the keys.) Added new username & password parameters so that users can define their desired credentials. If none are specified, then a random password is generated for the user "admin". (for user convenience & security) Updated README.md file with new parameters added and steps to take to retrieve the pem files without using curl. (initiate a shell session)
I'm very open to feedback and how I can improve the changes performed by myself.
Regards, Franklin E.
Hello @franklines!
Thanks for your support, it means a lot! I took a look at your pull request and there are a few things I would like to discuss with you.
-I understand your concern about the admin keys and I think it can be improved. The point of this container is to easily get started. With this in mind, may I suggest the creation of an argument that will disable the access to the keys as opposed to removing it? -For the sake of simplicity, I would prefer to have a default password instead of a randomly generated one. Again, this is to ensure an ease of use. The password can be updated later on if needed. -See other various comments.
Thanks again for this PR! Clement