gelf-php icon indicating copy to clipboard operation
gelf-php copied to clipboard

Remove none existing null handling in UdpTransport

Open simonberger opened this issue 1 year ago • 0 comments

After upgrading from version 1.6.4 to 2.0.1 we got a crash because of a passed null host value to the UdpTransport class in a pipeline, which was an unexpected break but obviously not unknown when types are introduced.

When looking at the class I noticed the null comments and checks were still in place which this PR intends to fix. I realized the two checks should stay because they are still checking for empty strings.

The MR ended up being very minor but fixing some more none strict checks which are safe because the type is given. Feel free to merge or (partly) take into any other commit.

simonberger avatar Apr 22 '24 15:04 simonberger