byuweb
fix: remove automatically setting background to white
Summary of Changes
What did you change? If this is a bug fix, how did you fix it?
The documentation already specifies that the developer should take care to use FAFAFA for the background. Doing it for them interferes with switching between a dark and light theme.
If this fixes styling, please include before and after screenshots!
Browser Testing
I have tested these changes in:
Add an x in all the boxes that apply. Please mark desktop and mobile browsers separately.
Desktop Browsers
- [ ] Google Chrome
- [ ] Mozilla Firefox
- [ ] Apple Safari
- [ ] Microsoft Edge
Mobile Browsers
- [ ] Any browser on iOS
- [ ] Chrome for Android
- [ ] Firefox Mobile for Android
We support the last two versions of Chrome, Firefox, Safari, and Edge.
@stuft2 I'm surprised that this hasn't been reviewed by anyone yet.
It looks like you need to perform an audit fix or remove the audit check from the pipeline. Also, I assume that you tested this in the UI with varying background colors?
Hey @Gi60s! Yes, tested it with a dark background color. Removing that style allowed me to toggle seamlessly between a light and dark byu theme.
There's been some internal conversations expressing some concerns with how this might negatively impact users downstream if they aren't specifying the off-white bg color already as directed in the usage instructions.