deep-fluids icon indicating copy to clipboard operation
deep-fluids copied to clipboard

Why `curl` in `build_test_model` rather than `jacobian3`?

Open vivanov879 opened this issue 4 years ago • 2 comments

Hi @byungsook. In the build_test_model function, curl is used:


            self.G_ = curl(self.G_s)

while in build_model method, jacobian3 is called:

            _, self.G_ = jacobian3(self.G_s)

why is it so? I am looking to advect the model predictions in order to obtain files in .vdb format. Thus, I plan to use jacobian3 call just like when training, and then use the advect method from smoke3_vel_buo.py script.

vivanov879 avatar Nov 08 '20 12:11 vivanov879

I believe jacobian3 also returns curl. However, the dimensions do not match what curl returns.

vivanov879 avatar Nov 09 '20 07:11 vivanov879

that's a bug, I will fix it, thanks for your report.

byungsook avatar Nov 19 '20 14:11 byungsook