spydrnet icon indicating copy to clipboard operation
spydrnet copied to clipboard

Published 20 hours ago • verified publisher icon byuccl

HTML Composer 1 - IR changes

Open ganeshgore opened this issue 3 years ago • 5 comments

I used many shortcuts while creating HTML composer, so I am trying to split them into multiple pull requests. This pull request contains additions in ir classes, I tried to add tests also but I guess that will keep evolving. We can discuss functionality in more detail and the required tests.

ganeshgore avatar Oct 21 '21 20:10 ganeshgore

Those added shortcuts in the IR look good! I'm guessing it's failing the Python 3.5 test because of OrderedDict().

jacobdbrown4 avatar Oct 26 '21 23:10 jacobdbrown4

yes I will fast-forward this once we merge #161, that should fix it

ganeshgore avatar Oct 27 '21 01:10 ganeshgore

I'm going to wait to merge this until we know our plan with extending classes.

jacobdbrown4 avatar Nov 02 '21 22:11 jacobdbrown4

Now that extending classes with extensions is an option, would you be able to make the html composer into an extension?

jacobdbrown4 avatar Jan 02 '22 00:01 jacobdbrown4

The ganesh_contributions branch was deleted, so the pull request automatically closed. I recreated the branch, reopened the pull request, changed the target branch to next_release, then deleted ganesh_contributions again. For some reason now in the comments above it says the wirthlin deleted next_release but that is not right. He deleted ganesh_contributions. I just thought I would clarify that in a comment here.

jacobdbrown4 avatar Sep 12 '23 21:09 jacobdbrown4