yi-note icon indicating copy to clipboard operation
yi-note copied to clipboard

Yinote window doesnt close in Chrome

Open gandalf34 opened this issue 4 years ago • 21 comments

Describe the bug

The yinote window open on the right hand side close in firefox but doesnt close in Chrome.

To Reproduce Steps to reproduce the behavior:

  1. Click on extension . Yinote will open
  2. Click on the arrow > at he right hand side of the Search field.
  3. Nothing happens.

Expected behavior It is expected to close by sliding to the right

Screenshots If applicable, add screenshots to help explain your problem.

Browser (please complete the following information): -Version 96.0.4664.45 (Official Build) (64-bit)

Additional context Add any other context about the problem here

https://user-images.githubusercontent.com/86377241/143216583-cb9f1214-0580-4f7d-af34-53f552c9e92d.mp4

.

gandalf34 avatar Nov 24 '21 09:11 gandalf34

Agree, this makes for a BAD experience. You can hit the refresh button and that gets rid of it.

hawkiboy avatar Jan 04 '22 03:01 hawkiboy

I have the same issue

Broodlisk avatar Feb 26 '22 07:02 Broodlisk

Same issue for me. I'm on Chrome Version 99.0.4844.74 (Official Build) (64-bit)

quentin-mckay avatar Mar 19 '22 09:03 quentin-mckay

The same thing happens to me.

rcsoul avatar Mar 30 '22 08:03 rcsoul

Same in Brave-Browser

christopher-nies avatar Mar 30 '22 08:03 christopher-nies

same as #105

phanirithvij avatar May 25 '22 10:05 phanirithvij

No fix yet?

No2515 avatar Jul 23 '22 23:07 No2515

I have the same issue

nikevelik avatar Jul 25 '22 12:07 nikevelik

@shuowu I've been debugging this issue and it seems to be related to the file packages/extension/src/ui/containers/App/styled.js on the transform property:

export const StyledDrawer = styled.div`
  ...

  transition: transform 0.3s;
  /* it's not updating the value, but props.open does change. Maybe some cache issue? */
  transform: ${props => (props.open ? 'translateX(0)' : 'translateX(100%)')}; 

  ...
`;

I'll keep digging but if you know how to fix it please let me know.

lemattma avatar Aug 03 '22 14:08 lemattma

I've created a PR fixing this issue: https://github.com/shuowu/yi-note/pull/113

lemattma avatar Aug 04 '22 09:08 lemattma

@shuowu can you help to review this PR and release a new version

I've created a PR fixing this issue: #113

hh23485 avatar Sep 05 '22 03:09 hh23485

I would love to help but I'm a total noob

On Sun, Sep 4, 2022 at 11:46 PM hh23485 @.***> wrote:

@shuowu https://github.com/shuowu can you help to review this PR and release a new version

I've created a PR fixing this issue: #113 https://github.com/shuowu/yi-note/pull/113

— Reply to this email directly, view it on GitHub https://github.com/shuowu/yi-note/issues/106#issuecomment-1236513743, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZ5J7GQ7A3LW2T4OKEUDCWDV4VUJXANCNFSM5IVUBRXQ . You are receiving this because you commented.Message ID: @.***>

No2515 avatar Sep 05 '22 08:09 No2515

Any updates here?

hh23485 avatar Nov 03 '22 11:11 hh23485

There seems to be numerous PR's to this extension to fix this issue, but this problem is still prevalent way into 2023...

shoneriki avatar Jun 14 '23 02:06 shoneriki

july 2023 and its still there , didnt got fixed yet??

ThDag avatar Jul 28 '23 16:07 ThDag

july 2023 and its still there , didnt got fixed yet??

no, the issue hasn't been fixed yet

shoneriki avatar Jul 28 '23 21:07 shoneriki

i have found a %1000 better tool to take notes on videos thats faster, easier, cleaner

idk if its rude but there is just no way i can use with the bugs and no maintenance

its NattyNote its very not known i found it in some reddit post

you can find it in chrome web store

instead of creating a webpage to store and the notes you took across web, it caches the youtube link so all the notes are in the same place as the video and there is a list of cached files

it stores way less space on the screen after all you need to see when noting a quick sentence is the the text, better then covering the whole side of the screen

ThDag avatar Aug 11 '23 19:08 ThDag

trash

Medullitus avatar Aug 12 '23 21:08 Medullitus

why

ThDag avatar Aug 13 '23 08:08 ThDag

We can use an alternative for closing the left pane of yinote by refreshing your web page. Press Crtl+r to refresh it quickly and it will disappear

mbalassane avatar Oct 25 '23 11:10 mbalassane

Issue has been fixed in version 1.8.0 in both chrome & edge store (pending store review, it will be available in store soon)!

shuowu avatar Feb 18 '24 13:02 shuowu