Jack Farley

Results 42 comments of Jack Farley

> I prefer standalone docker files, i.e. `git clone` within the image build and not before > > reduces build steps and errors on the end user side > >...

> We may want to utilize GitHub actions to do the final build/push to docker hub as well. I'd be in favour of remaining on docker hub, but if we...

@raucao I did start making changes and looking at it. I unfortunately ran out of time before going on a trip. I was going to merge the two dockerfiles and...

Sorry about the delay. Have done a bit of merging between the two Dockerfiles: * basing it off alpine with a build container, I got it down to 49MB *...

Hey @JakubNer. Hmm, that's weird. Just tried running through the build process again and no issues for me (commands below). Is the image [bytesnz/armadietto:latest](https://hub.docker.com/r/bytesnz/armadietto) working for you (is built off...

> So I don't understand why the linked `/usr/local/bin/armadietto` invocation run inside that image doesn't execute when I re-build locally. @JakubNer oooo that is weird. If you shell into your...

In terms of the tasks: * complete github action file (or complete later) Looking at now (https://github.com/bytesnz/armadietto/compare/add-dockerfile...bytesnz:expand-docker). Looking to: * run the tests in the action * allow the workflow...

With the tests, I was thinking it would be good idea to test the docker image to ensure the image is working as expected (the docker configuration is correct and...

> That sounds reasonable to me. If we build images for all tags, then we can test beta tags directly from the registry before tagging stable releases. Yeah. Ah... just...

> What does this mean? Is this some alternative to what you did whereby we'd use's npm's registry or some such? I don't see why we'd not want to do...