Noteslify
Noteslify copied to clipboard
bytemakers
Add Theming Option to the Notes and Homepage/everywhere else
Add the options of switching themes from light to dark theme with a toggle
I can do that. Let me do this as well.
Okay, have assigned you. But were you able to self-assign yourself as you have write access?
I'd like to work on implementing dark mode for all pages, please assign me. Or do I need to open a new issue?
I'd like to work on implementing dark mode for all pages, please assign me. Or do I need to open a new issue?
@nkirukka Hi, This issue is open and have assigned to you.
We are shifting to using Tailwind in Frontend CSS. ( Dashboard is not using Tailwind CSS, it's just the new landing page being developed for now ) You can help us out here as well 😄 https://github.com/dvstechlabs/Noteslify/issues/237
- Which of the folders should I work in? /frontend or /frontendnew?
- The page that opens on localhost:3000 from /frontend is different from the current live site and different from /frontendnew.
- Is there a color guide for dark theme or do I have creative liberty?
See attactment for better understanding
Current live
From /frontendnew
From /frontend
The navbar here specifically is different
@nkirukka
Which of the folders should I work in? /frontend or /frontendnew?
/frontendnew
The page that opens on localhost:3000 from /frontend is different from the current live site and different from /frontendnew.
Yes, since it's not running the latest version due to some under-development features like the folders section.
The older frontend landing page is no longer developed. ( Only the landing page )
The new production version once released will have the new landing page, all previous landing pages will be archived.
Is there a color guide for dark theme or do I have creative liberty?
Nothing specific for dark theme. Feel free to use what you think the best!!!
@nkirukka You can start working on it 🎉
Also, Could you make it in such a way that only adding the prefix dark: to any style element selects the dark theme for that element, for example, I wanted to make a title white in the dark theme and black in light theme, so I should be able to use <p className="text-black dark:text-white">Some Text</p>
Hope you get my point! And then you can continue to implement dark theme on all the pages!
Can I start working on this?
Sure @thevinitgupta Have assigned you the same.
Also, Could you make it in such a way that only adding the prefix
dark:to any style element selects the dark theme for that element, for example, I wanted to make a title white in the dark theme and black in light theme, so I should be able to use<p className="text-black dark:text-white">Some Text</p>
@devarshishimpi I have configured tailwind to do this as you asked.
But the pages accessible (like Pricing, Features) already have the dark mode options
While the Signup and Contact pages don't have any content.
Could you please clarify?
Also, Could you make it in such a way that only adding the prefix
dark:to any style element selects the dark theme for that element, for example, I wanted to make a title white in the dark theme and black in light theme, so I should be able to use<p className="text-black dark:text-white">Some Text</p>@devarshishimpi I have configured
tailwindto do this as you asked. But the pages accessible (like Pricing, Features) already have the dark mode options While the Signup and Contact pages don't have any content.Could you please clarify?
Yes, that's great. You can raise a PR for the same. Sign-up and Contact Pages haven't been made yet.