gopkg icon indicating copy to clipboard operation
gopkg copied to clipboard

Unit tests randomly fail

Open zhangyunhao116 opened this issue 3 years ago • 7 comments

https://github.com/bytedance/gopkg/runs/2526939630

zhangyunhao116 avatar May 11 '21 02:05 zhangyunhao116

CC @PureWhiteWu

zhangyunhao116 avatar May 11 '21 03:05 zhangyunhao116

我之前和 github support 联系过了,目前没有办法提升 runner 配置。 目前有两个思路解决这个问题:

  1. 采用 self-hosted runner;
  2. 删除这些会随机失败的 ut。

PureWhiteWu avatar May 11 '21 03:05 PureWhiteWu

Maybe makes the unit tests suitable for different machines is a better idea.

zhangyunhao116 avatar May 11 '21 06:05 zhangyunhao116

Can we please be more specific?
like listing all the unstable testcases, steps to reproduce, reasons for failure, etc.

If not all of them failed for the same reason, guess we may have to create different issues for different cases.

luchsh avatar May 11 '21 06:05 luchsh

Can we please be more specific? like listing all the unstable testcases, steps to reproduce, reasons for failure, etc.

If not all of them failed for the same reason, guess we may have to create different issues for different cases.

主要还是因为有一些 test 依赖时间进行测试,而在 github actions 上性能比较差,所以一旦有抖动就挂了……

PureWhiteWu avatar May 11 '21 07:05 PureWhiteWu

Can we please set up some “ self-hosted runners"? it sounds more straightforward

luchsh avatar Oct 12 '21 12:10 luchsh

FYI: @PureWhiteWu 申请了公司的 github runner,不久后应该就能解决这个问题。

SilverRainZ avatar Oct 29 '21 08:10 SilverRainZ