bitsail
bitsail copied to clipboard
[Improve][Connector] Change `path_list` option setting using concating string with comma `,` to string list for FtpConnector
Description
For FtpConnector, currently we can specify directories to read by setting configuration json file using option path_list, but it can't specify several files' path to read.
Suggetion:
- currently
path_listspecify a string contains path list, it is better to change to specify a string list like below - update documentation of
FtpCoinnector
"reader": {
"path_list": ["/data/json/upload1/test1.json", "/data/json/upload2/"]
}
BitSail Component or Code Module
BitSail Connector
Are you willing to submit PR?
- [ ] Yes, I am willing to submit a PR!
Code of Conduct
- [X] I agree to follow this project's Code of Conduct
This issue maybe good for beginner.
@Jake-00 Thanks for your issue, you suggestion is we just not support directories right, we can use file path directly?
@hk-lrzy To read directories already support, but to read multiple specified files do not support yet.
@hk-lrzy To read directories already support, but to read multiple specified files do not support yet.
I see, can you use same parameter to support? like we check the path is file or directory, if directory we support to list it and if it is file we support read it directly.
I don't want to add parameter because user need to know use which one, it's not necessary for user.
Sounds more reasonable, shall I change the issue description?
Sounds more reasonable, shall I change the issue description?
Sure~
When diving deeper in FtpConnector, it already supports to read specified files and directories. Issue description is wrong and I change the description of this issue. Could we add tag good-first-issue?