wasmtime icon indicating copy to clipboard operation
wasmtime copied to clipboard

c-api: add wasm_config_parallel_compilation_set

Open thibaultcha opened this issue 3 years ago • 3 comments

This has not been discussed in issues and I do not believe there are tests cases for the config C API. Nevertheless, could we add this flag in the C API with this small changeset?

thibaultcha avatar Nov 18 '22 19:11 thibaultcha

Subscribe to Label Action

cc @peterhuene

This issue or pull request has been labeled: "wasmtime:c-api"

Thus the following users have been cc'd because of the following labels:

  • peterhuene: wasmtime:c-api

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

github-actions[bot] avatar Nov 18 '22 21:11 github-actions[bot]

Subscribe to Label Action

cc @peterhuene

This issue or pull request has been labeled: "wasmtime:api", "wasmtime:config"

Thus the following users have been cc'd because of the following labels:

  • peterhuene: wasmtime:api

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

github-actions[bot] avatar Nov 21 '22 21:11 github-actions[bot]

Label Messager: wasmtime:config

It looks like you are changing Wasmtime's configuration options. Make sure to complete this check list:

  • [ ] If you added a new Config method, you wrote extensive documentation for it.

    Our documentation should be of the following form:

    Short, simple summary sentence.
    
    More details. These details can be multiple paragraphs. There should be
    information about not just the method, but its parameters and results as
    well.
    
    Is this method fallible? If so, when can it return an error?
    
    Can this method panic? If so, when does it panic?
    
    # Example
    
    Optional example here.
    
  • [ ] If you added a new Config method, or modified an existing one, you ensured that this configuration is exercised by the fuzz targets.

    For example, if you expose a new strategy for allocating the next instance slot inside the pooling allocator, you should ensure that at least one of our fuzz targets exercises that new strategy.

    Often, all that is required of you is to ensure that there is a knob for this configuration option in wasmtime_fuzzing::Config (or one of its nested structs).

    Rarely, this may require authoring a new fuzz target to specifically test this configuration. See our docs on fuzzing for more details.

  • [ ] If you are enabling a configuration option by default, make sure that it has been fuzzed for at least two weeks before turning it on by default.


To modify this label's message, edit the .github/label-messager/wasmtime-config.md file.

To add new label messages or remove existing label messages, edit the .github/label-messager.json configuration file.

Learn more.

github-actions[bot] avatar Nov 21 '22 21:11 github-actions[bot]

Can we restart the CI on this one? I don't think the failures are related; and we'd really like this being part of the next release if possible so that we don't lag too far behind the latest Wasmtime version...

thibaultcha avatar Nov 29 '22 22:11 thibaultcha

Oh sorry missed the updates here, could you try rebasing? That known flaky test has been fixed on main

alexcrichton avatar Nov 29 '22 22:11 alexcrichton

Ah, excellent, done!

thibaultcha avatar Nov 29 '22 22:11 thibaultcha