wasmtime icon indicating copy to clipboard operation
wasmtime copied to clipboard

Published 20 hours ago • verified publisher icon bytecodealliance

fuzzgen: Always generate reachable blocks

Open afonso360 opened this issue 3 years ago • 1 comments
trafficstars

👋 Hey,

This PR alters fuzzgen to always generate reachable blocks. See #5022 for context.

We do this by making sure that whenever we insert terminators at least one of the edges points to the next block.

Another thing this PR does is separate the CFG construction from block terminator insertion.

This fuzzed ok individually, but I'm now also testing with #5020 on top to see if it finds anything else.

cc: @jameysharp

afonso360 avatar Oct 08 '22 20:10 afonso360

I used all my brain today on reviewing the egraphs PR and can't give this the attention I'd like to. @cfallin, could you verify that this implementation of CFG generation makes sense to you, and merge this if so?

Certainly; I owe you several brain refills for that review, thanks! I'll take a look at this PR tomorrow.

cfallin avatar Oct 12 '22 01:10 cfallin