wasmtime icon indicating copy to clipboard operation
wasmtime copied to clipboard

ISLE: Resolve overlap in prelude.isle and x64/inst.isle

Open elliottt opened this issue 3 years ago • 1 comments

Resolve overlap in the ISLE prelude and the x64 inst module by introducing new types that allow better sharing of extractor resuls, or falling back on priorities.

This PR makes the following changes in overlap counts for the different backends:

branch x64 aarch64 s390x
main 168 214 446
this 138 212 440

elliottt avatar Sep 22 '22 00:09 elliottt

Subscribe to Label Action

cc @cfallin, @fitzgen

This issue or pull request has been labeled: "cranelift", "cranelift:area:machinst", "cranelift:area:x64", "isle"

Thus the following users have been cc'd because of the following labels:

  • cfallin: isle
  • fitzgen: isle

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

github-actions[bot] avatar Sep 22 '22 01:09 github-actions[bot]

I want to give this one more review pass after my first meeting this morning, but I think this is in great shape and I'm expecting to add my approval to the one Chris already left.

jameysharp avatar Sep 26 '22 16:09 jameysharp