Rename `MmapVec::drain` to `split_off`

Open alexcrichton opened this issue 3 years ago • 1 comments

As suggested on #4609

Aug 10 '22 15:08 alexcrichton

Subscribe to Label Action

cc @peterhuene

This issue or pull request has been labeled: "wasmtime:api"

Thus the following users have been cc'd because of the following labels:

peterhuene: wasmtime:api

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

Aug 10 '22 17:08 github-actions[bot]

I've pushed an alternative on top of this branch, to exactly match the behavior of Vec::split_off in MmapVec. Would you review it and merge if you're happy with it?

Aug 15 '22 15:08 jameysharp

Looks good to me!

It also looks like github is smart enough to prevent me from approving my own PR, so I'll need your stamp as well for the merge.

Aug 15 '22 17:08 alexcrichton