wasmtime icon indicating copy to clipboard operation
wasmtime copied to clipboard

Update `wasi-crypto`

Open rjzak opened this issue 3 years ago • 9 comments

  • This has been discussed in issue #4610.
  • Update wasi-crypto
  • Test Wasm https://github.com/rjzak/wasi-crypto-example/releases/tag/v0.0.1

CC: @npmccallum, @sunfishcode

rjzak avatar Aug 04 '22 15:08 rjzak

@sunfishcode Can we get some attention on this?

npmccallum avatar Aug 17 '22 14:08 npmccallum

@rjzak -- Looking good now! Thanks!

Would you mind resolving the conflict so it can be merged?

jedisct1 avatar Sep 14 '22 18:09 jedisct1

@jedisct1 ~I'd like to resolve the conflict, but I changed the Cargo.toml file and need it to have my version, not what this thing is that Git seems to be trying to merge. How can I force it to be my version?~ Resolved!

rjzak avatar Sep 14 '22 22:09 rjzak

@jedisct1 I could use some advice regarding some of the CI errors. A lot of these are not related to wasi-crypto.

rjzak avatar Sep 19 '22 13:09 rjzak

I added the nightly requirement for wasmtime-wasi-crypto since wasi-crypto uses Cargo's "per-package-target" https://github.com/WebAssembly/wasi-crypto/compare/67d9821f2763f4626a97c70c411ccb92a2047712...fa309ace2bb335bb08efc724a18721e8217d5977#diff-9c249d46387da48fcc9d73b78e7a99a00bb825ae6b5fa222b60f6b27f9a4d2a0. Is this ok @sunfishcode?

rjzak avatar Sep 19 '22 14:09 rjzak

@rjzak I don't think nightly is required (at least I hope it's not...)

However, the errors about dead code were likely due to the example main.rs file in wasi-crypto/.../bindings/rust/src.

This has been fixed upstream, so an update to a more recent commit should fix the issues we are seeing here as well.

jedisct1 avatar Sep 19 '22 14:09 jedisct1

Nightly was only needed for running the test case for Wasi-Crypto, not for compiling the Wasmtime-Wasi-Crypto module.

I'll look at updating the Wasi-Crypto submodule.

rjzak avatar Sep 19 '22 15:09 rjzak

Yes, but the test case depends on the Rust example bindings.

jedisct1 avatar Sep 19 '22 15:09 jedisct1

I've updated the Wasi-Crypto git submodule, may I have a re-run of CI? @sunfishcode or @jedisct1 This should fix one of the CI issues about unused import.

Edit: nevermind, CI just decided to run as soon as I made this comment?

rjzak avatar Oct 07 '22 20:10 rjzak

Abandoning in favour of future PR against the main branch.

rjzak avatar Oct 18 '22 16:10 rjzak