wasmtime icon indicating copy to clipboard operation
wasmtime copied to clipboard

Published 20 hours ago • verified publisher icon bytecodealliance

Remove two instruction terminator sequences

Open bjorn3 opened this issue 1 year ago • 1 comments

Feature

Replace sequences like brz+jump and brnz+jump with single instructions.

Benefit

Simplifies code. These sequences are a leftover from the migration from EBB's to BB's quite a while ago.

Implementation

TBD

Alternatives

Keep the current state at the cost of more complex code.

bjorn3 avatar Jul 31 '22 19:07 bjorn3

This would be a nice simplification, I think. One potential issue to check for would be whether InstructionData grows as a result of two branch targets rather than one. Otherwise this fits more nicely with the structure in the rest of the compiler (including branches in VCode).

cfallin avatar Aug 01 '22 17:08 cfallin

This has been fixed. I believe in https://github.com/bytecodealliance/wasmtime/pull/5630.

bjorn3 avatar Nov 28 '23 16:11 bjorn3