wasmtime icon indicating copy to clipboard operation
wasmtime copied to clipboard

Published 20 hours ago • verified publisher icon bytecodealliance

Use debug! logging instead of info! for verbose logging

Open rylev opened this issue 5 years ago • 5 comments
trafficstars

This issue has not been discussed, but I believe it simple enough that a discussion wasn't needed. The info! log is meant for high level logs that are relevant to every invocation. The logs in this PR are only relevant when debugging so they should use the debug! logging macro.

I'm not sure who should look at this, but perhaps @peterhuene can take a look.

rylev avatar Apr 17 '20 12:04 rylev

Subscribe to Label Action

cc @bnjbvr

This issue or pull request has been labeled: "cranelift", "cranelift:module", "cranelift:wasm"

Thus the following users have been cc'd because of the following labels:

  • bnjbvr: cranelift

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

github-actions[bot] avatar Apr 17 '20 12:04 github-actions[bot]

@sunfishcode no it doesn't seem like there's good docs on when to use which log. From what I've seen out there

  • info is high-level logs that you'd want to show on every normal run of the program
  • warn is something went wrong but it's not fatal and should just be checked out when you have a chance
  • error an error occured. It's not enough to crash the program but it's something that should be looked into ASAP *debug any info that would be relevant to see the flow of the executing program
  • trace very verbose logs. Generally not helpful for program wide debugging but useful when inspecting a small segment of the program.

rylev avatar Apr 17 '20 15:04 rylev

It looks like CI failed to build because ld couldn't link, but it gave no discernible diagnostic message, just returned an exit code of 1. Hopefully just a transient failure.

That always happens for me when the disk is full.

bjorn3 avatar Apr 17 '20 18:04 bjorn3

The failure is that CI is running out of disk space and we have some PRs up that will hopefully help mitigate the problem shortly.

peterhuene avatar Apr 17 '20 19:04 peterhuene

@peterhuene This should be good to go now. Sorry for the delay!

rylev avatar May 06 '20 09:05 rylev

@rylev I'm cleaning up old PRs and came upon this; are you still interested in this change? (Lots of conflicts now but it seems it wouldn't be too hard to redo the change in general) Sorry this got dropped on the floor beforehand!

cfallin avatar Feb 09 '23 00:02 cfallin

@cfallin no worries! I'll close this. The user can always filter the logs fairly easily if it's too verbose.

rylev avatar Feb 09 '23 08:02 rylev