wasmtime icon indicating copy to clipboard operation
wasmtime copied to clipboard
verified publisher icon bytecodealliance

Test out s390x inline assembly change in isolation

Open alexcrichton opened this issue 6 months ago • 2 comments

Extracted from #10960

prtest:linux-s390x

alexcrichton avatar Jun 06 '25 23:06 alexcrichton

I'm pretty perplexed staring at this one too -- for reference here are Godbolt links for before (working) and after (apparently segfaulting). The clobber-saves come in different order wrt loading values into payload (r6/r7) but the dataflow from arguments to PC/SP (r15)/payload (r6, r7) looks completely equivalent...

cfallin avatar Jun 06 '25 23:06 cfallin

cc @uweigand would you be able to help dig in to what's going on here? (we can provide more background context if necessary, but the general gist is that this PR in theory is a refactoring that shouldn't do anything but it causes tests to segfault)

alexcrichton avatar Jun 07 '25 00:06 alexcrichton

I was finally able to reproduce this. Turns out the crash only happens when building with CARGO_INCREMENTAL=0.

uweigand avatar Jul 02 '25 17:07 uweigand

Ok this should be good to go now, thanks again @uweigand!

alexcrichton avatar Jul 02 '25 20:07 alexcrichton

ping @pchickey, mind taking a look at this? (I can also reassign if you'd like too)

alexcrichton avatar Jul 11 '25 15:07 alexcrichton