wasmtime-py icon indicating copy to clipboard operation
wasmtime-py copied to clipboard

Component binding class naming issue

Open Mossaka opened this issue 2 years ago • 1 comments

I was playing around the component model demo example listed in README. One issue I found with that is the python class Demo name is generated from the wasm file name. This is error-prone because I could rename the wasm name to demo.component.wasm and the generated Demo.component class name in Python is a syntax error.

How to reproduce

Go through the first demo example under the "Components" section. Change the commands to the following

$ wasm-tools component new demo.wat --wit demo.wit -o demo.component.wasm
$ python -m wasmtime.bindgen demo.component.wasm --out-dir demo

Notice how "demo.wasm" is replaced with "demo.component.wasm".

Then notice that the generated python file contains syntax error because the Demo class name is now replaced with Demo.component class name in demo/__init__.py

Mossaka avatar Jan 09 '23 00:01 Mossaka