wasmtime-go
wasmtime-go copied to clipboard
test: Conduct testify testing framework
Looks like a great start to me, indeed it's much cleaner!
Haha Thanks. There are still a lot of change should be taken. I will add them in the coming a few days.
failing tests are originally failed. We need another PR to fix them
@howjmay 👋 Are you still working on this, and do you need any help? It'd be great to have this updated and merged.
@fgsch Sorry I was busy in the past days and forget this one. Let me keep working on it
@fgsch I solved the problems in the tests, but it seems I need to set up some dependencies of bazel for the new testing framework package. Could you help me solve the problems?
@fgsch I solved the problems in the tests, but it seems I need to set up some dependencies of bazel for the new testing framework package. Could you help me solve the problems?
I'm looking at the error now.
@howjmay I don't have permissions to push to your branch so I have created a gist with 2 commits to fix this:
https://gist.github.com/fgsch/da3906ed7353d5b12dc8e402030e948a
The last one is not mandatory but it'd save people from some potential pain.
Oh, and I have left another (non-blocking) comment about the changes in trap.go.
Hi @fgsch i still can't pass the test. Could you help me?
@howjmay I think you applied the last commit in my gist to the wrong srcs.
It needs to be done for the go_default_test
case, not the go_default_library
one.
Thanks again @howjmay!