wasmtime-go icon indicating copy to clipboard operation
wasmtime-go copied to clipboard

test: Conduct testify testing framework

Open howjmay opened this issue 2 years ago • 3 comments

howjmay avatar Apr 14 '22 14:04 howjmay

Looks like a great start to me, indeed it's much cleaner!

alexcrichton avatar Apr 14 '22 15:04 alexcrichton

Haha Thanks. There are still a lot of change should be taken. I will add them in the coming a few days.

howjmay avatar Apr 14 '22 15:04 howjmay

failing tests are originally failed. We need another PR to fix them

howjmay avatar Apr 27 '22 10:04 howjmay

@howjmay 👋 Are you still working on this, and do you need any help? It'd be great to have this updated and merged.

fgsch avatar Aug 18 '22 20:08 fgsch

@fgsch Sorry I was busy in the past days and forget this one. Let me keep working on it

howjmay avatar Aug 19 '22 07:08 howjmay

@fgsch I solved the problems in the tests, but it seems I need to set up some dependencies of bazel for the new testing framework package. Could you help me solve the problems?

howjmay avatar Aug 19 '22 13:08 howjmay

@fgsch I solved the problems in the tests, but it seems I need to set up some dependencies of bazel for the new testing framework package. Could you help me solve the problems?

I'm looking at the error now.

fgsch avatar Aug 22 '22 08:08 fgsch

@howjmay I don't have permissions to push to your branch so I have created a gist with 2 commits to fix this:

https://gist.github.com/fgsch/da3906ed7353d5b12dc8e402030e948a

The last one is not mandatory but it'd save people from some potential pain.

fgsch avatar Aug 22 '22 12:08 fgsch

Oh, and I have left another (non-blocking) comment about the changes in trap.go.

fgsch avatar Aug 22 '22 12:08 fgsch

Hi @fgsch i still can't pass the test. Could you help me?

howjmay avatar Aug 25 '22 08:08 howjmay

@howjmay I think you applied the last commit in my gist to the wrong srcs. It needs to be done for the go_default_test case, not the go_default_library one.

fgsch avatar Aug 25 '22 12:08 fgsch

Thanks again @howjmay!

alexcrichton avatar Aug 30 '22 20:08 alexcrichton