wasm-micro-runtime icon indicating copy to clipboard operation
wasm-micro-runtime copied to clipboard

Set is_binary_freeable in load_from_sections

Open jammar1 opened this issue 4 months ago • 2 comments

Hi,

I'm not sure this is the correct way to solve this crash.

When I upgraded to Wamr 2.4.1, I found that it was now crashing when calling wasm_store_delete with: module error for object 0x120440078: pointer being freed was not allocated.

I think #3983 causes this issue, because module->is_binary_freeable is always set to false in create_module here: https://github.com/bytecodealliance/wasm-micro-runtime/blob/main/core/iwasm/aot/aot_loader.c#L4206 - even when clone_wasm_binary is set to false in the load args.

We don't set it for the module until here https://github.com/bytecodealliance/wasm-micro-runtime/blob/main/core/iwasm/common/wasm_runtime_common.c#L1492 after aot_load_from_aot_file has returned so it cannot be correct when we use it in the loader.

Thanks

jammar1 avatar Sep 01 '25 19:09 jammar1

Do you happen to have a minimal reproducible example? I wonder why was that not captured in our tests.

loganek avatar Sep 02 '25 13:09 loganek

@jammar1 Would you mind sharing the steps to reproduce the issue?

lum1n0us avatar Sep 12 '25 01:09 lum1n0us