wasm-micro-runtime icon indicating copy to clipboard operation
wasm-micro-runtime copied to clipboard

Published 20 hours ago • verified publisher icon bytecodealliance

Add file and line number to LOG_ macros

Open sjamesr opened this issue 1 year ago • 2 comments

sjamesr avatar Aug 17 '24 23:08 sjamesr

Built at 740f499e9, libiwasm.so ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, stripped goes from 459608 bytes to 463704 bytes, so around a 1% increase.

Is libiwasm.so size a representative check? Should I be looking at something else?

sjamesr avatar Aug 19 '24 06:08 sjamesr

I also think it was omitted intentionally, per my understanding, this PR makes the log look ugly and not easy to read, and now only LOG_FATAL and LOG_DEBUG dump the file info and line number. I am not sure why you need to dump so much detailed info? Since normally you can get the file and line number by searching the log string in the wamr folder.

wenyongh avatar Aug 19 '24 10:08 wenyongh