wasm-micro-runtime icon indicating copy to clipboard operation
wasm-micro-runtime copied to clipboard

Published 20 hours ago • verified publisher icon bytecodealliance

Implement dynamic linking section loading

Open loganek opened this issue 1 year ago • 3 comments

Also added build flags to enable dynamic linking

Please note this PR includes two extra commits:

  • https://github.com/bytecodealliance/wasm-micro-runtime/commit/fecd383c94bbc560eb7485e5c31fbd22f4272da8
  • https://github.com/bytecodealliance/wasm-micro-runtime/commit/da31c079b2fd39cbaa4f7c8a7b937fb783876b82

If we could merge main to the dev/dynamic_linking it'd probably make the PR cleaner. @wenyongh could you help with that?

loganek avatar Aug 15 '24 09:08 loganek

Also added build flags to enable dynamic linking

Please note this PR includes two extra commits:

If we could merge main to the dev/dynamic_linking it'd probably make the PR cleaner. @wenyongh could you help with that?

@loganek done with #3723.

wenyongh avatar Aug 15 '24 12:08 wenyongh

Shall we start to implement missing spec content?

  • import memory
  • import table
  • instantiation linking

If not starting, I am able to take them.

lum1n0us avatar Aug 15 '24 13:08 lum1n0us

Shall we start to implement missing spec content?

  • import memory
  • import table
  • instantiation linking

If not starting, I am able to take them.

thanks a lot for offering a help. So I've started with the section loader as this is something we'll have to do anyway and it's probably the least controversial one. I've started experimenting with other stuff but I'd be grateful for any help; I'll reach out on zulip to discuss some details.

loganek avatar Aug 15 '24 13:08 loganek

Could you rebase the code with main branch? A CI issue was fixed with ##3764

wenyongh avatar Sep 09 '24 10:09 wenyongh

Could you rebase the code with main branch? A CI issue was fixed with ##3764

done

loganek avatar Sep 09 '24 10:09 loganek

Could you rebase the code with main branch? A CI issue was fixed with ##3764

done

Seems not rebased? The CI still reported the same error: https://github.com/bytecodealliance/wasm-micro-runtime/actions/runs/10771650997/job/29868504952#step:14:118

Cloning into 'spec'...
~/work/wasm-micro-runtime/wasm-micro-runtime/tests/wamr-test-suites/workspace/spec ~/work/wasm-micro-runtime/wasm-micro-runtime/tests/wamr-test-suites/workspace
fatal: Could not parse object '48e69f394869c55b7bbe14ac963c09f4605490b6'.

wenyongh avatar Sep 09 '24 11:09 wenyongh

Sorry that I didn't realize this PR is to merge to dev/dynamic_linking branch and some commits in main branch hadn't been merged to it yet, so the CI still reported error.

I just merged main into dev/dynamic_linking, could you rebase again?

wenyongh avatar Sep 10 '24 03:09 wenyongh