wasm-micro-runtime icon indicating copy to clipboard operation
wasm-micro-runtime copied to clipboard

execute_func: Newline only for non-empty returns

Open wallento opened this issue 1 year ago • 3 comments

For void functions, the return value array is empty. Don't print the newline then.

wallento avatar Jul 22 '24 16:07 wallento

doesn't this confuse programs parsing the output, like our test scripts?

yamt avatar Jul 23 '24 06:07 yamt

I am happy to adopt the test scripts then, but so far I am not sure if thats the reason for the 9 failing checks. Those are just empty lines without useful information, there must be a better way to test if needed. Overall, I think this feature is not really useful for embedding wamr, as it always prints this information. I am also happy to adopt it to only print given certain defines.

wallento avatar Jul 23 '24 06:07 wallento

The failing checks all seem timeouts, so I think no test checks for this.

wallento avatar Jul 23 '24 06:07 wallento

The failing checks all seem timeouts, so I think no test checks for this.

i guess a test timeout is actually a typical symptom of unexpected output. i can't say if they are related to your change or not w/o investigating the test logs. (sorry, right now i have no time to investigate them by myself.)

yamt avatar Feb 06 '25 04:02 yamt