rfcs icon indicating copy to clipboard operation
rfcs copied to clipboard

Add "A Cranelift Assembler"

Open abrown opened this issue 11 months ago • 2 comments

Rendered

abrown avatar Dec 10 '24 23:12 abrown

Should we consider merging this (i.e., start the "motion to finalize with a disposition to merge") and, if so, what should I update in the document? I think the details at the ISLE level are different now than when originally written and will likely continue to change, so perhaps this should articulate goals more than details?

abrown avatar Feb 28 '25 18:02 abrown

For what it's worth, for previous large Cranelift features where we wrote RFCs (e.g., ISLE, or the mid-end egraphs framework) the RFC was more of a snapshot of proposed design and we were fine to merge once discussion quelled. If you want to do updates here based on what we've discovered since December then that seems reasonable, I suppose, and probably better than merging something we know is now out-of-date, but this is just to say that it wouldn't be out-of-place if not (in the sense that other RFCs have not been updated since).

cfallin avatar Feb 28 '25 18:02 cfallin

I re-read through this today and I think the bulk of the content holds up without any changes. We've fine-tuned some bits in the last few months but the essence of this RFC remains the same. I'll paste in some text I found in a different PR to follow the process to merge this:


Motion to Finalize

Disposition: Merge


abrown avatar Jul 07 '25 20:07 abrown

As there has been signoff from representatives of two different BA stakeholder organizations, this RFC is now entering its 10-day

Final Comment Period

and the last day to raise concerns before this RFC merges is 2025-07-17.

abrown avatar Jul 07 '25 21:07 abrown