regalloc2 icon indicating copy to clipboard operation
regalloc2 copied to clipboard

adding feature to suport nightly features on dependencies

Open jakubDoka opened this issue 11 months ago • 3 comments

this resolves problems with feature unification and resolves https://github.com/bytecodealliance/regalloc2/issues/209

jakubDoka avatar Jan 24 '25 11:01 jakubDoka

https://github.com/bytecodealliance/regalloc2/actions/runs/12948971873/job/36118715209?pr=210 @cfallin this workflow most likely needs an update

jakubDoka avatar Jan 24 '25 11:01 jakubDoka

@jakubDoka feel free to update the GitHub CI configuration too: the all-features check can probably instead become a list of cargo check invocations with specific feature sets, e.g. no default features; std; std, checker; std, trace-log; std, serde; serde. Or something like that? Then separately a cargo +nightly check --features allocator-api?

cfallin avatar Jan 27 '25 01:01 cfallin

The need to do this has been resolved by updates to hashbrown (https://github.com/rust-lang/hashbrown/pull/606 solves the specific problem with hashbrown/nightly) and allocator-api2 (https://github.com/zakarumych/allocator-api2/pull/30 solves it for everyone else).

hanna-kruppe avatar Feb 23 '25 13:02 hanna-kruppe

This should now be fixed with the latest release of hashbrown.

Amanieu avatar Apr 30 '25 22:04 Amanieu