jco icon indicating copy to clipboard operation
jco copied to clipboard

chore(examples): add examples

Open vados-cosmonic opened this issue 1 year ago • 3 comments

This commit adds examples to the jco, some of which are/will be referenced from the component-model book (https://component-model.bytecodealliance.org/).

vados-cosmonic avatar Oct 02 '24 14:10 vados-cosmonic

I'm going to assume that the failing test is unrelated, considering none of the actually important code changed. Possibly a problem with ubuntu latest?

vados-cosmonic avatar Oct 02 '24 15:10 vados-cosmonic

Yes, just a flake.

guybedford avatar Oct 02 '24 16:10 guybedford

Hey @guybedford this is finally ready for review -- example CI is working properly

[EDIT] I'm also fine not committing the per-project WASM binaries -- so I could take those out... Would lighten the repo a bit

vados-cosmonic avatar Oct 02 '24 17:10 vados-cosmonic

Sorry for the delay, thanks for the detailed review -- I was able to hit everything!

vados-cosmonic avatar Oct 16 '24 08:10 vados-cosmonic