bytecodealliance
fix: cargo wasi test preopen cwd
This PR defaults cargo wasi test to always be run
with the current working directory preopened.
The goal is to allow existing tests to run without modification.
Fixes #128
Personally I'm not confident enough that this is the best way to approach this to merge. Part of WASI/wasm is the whole capability-based-security idea and implicitly granting access to things feels, at least to me, like it's going against that. I sympathize with the desire to run things out-of-the-box but that clashes with the capability goals of WASI where in theory the directories all need to be explicitly granted at some point.
I don't know personally how best to balance these concerns. Pushing entirely on "always say what you get" is not going to be fine but additionally implicitly granting access seems like it would inevitably cause issues as well.
I see cargo wasi test as a specific case, but I'm game to explore other options. I want to avoid always requiring command-line args for ergonomics.
A different approach could be to build out a custom section in Cargo.toml. If there is a section for WASI and various run modes like test, then cargo wasi could suggest defaults to add to the toml. When running cargo wasi test it would inspect global wasi configurations and run mode specific configurations. cargo component has its own component section, but at this time, WASI is a global context and perhaps should have its own section.
I agree that implicitly adding preopens is potentially hazardous, but if I'm reading the PR right, this only happens in test mode, in which case conveniences are always welcome in the pursuit of ergonomics.
Coming from looking at Deno recently, I see a lot of interest for it because of the security it gives users and companies that Deno will only give access to capabilities made explicit on the command line. And I worked on wasm with Go before WASI was a thing so I missed this boat and am trying to catch up a little now. I can say if I were to see the stack trace output from a simple cargo wasi test, 28 deep, with not piece of guidance in sight that directory access was needed, it would be daunting.
There's a tutorial for wasmtime that says an error about capabilities would be printed, error opening input test.txt: Capabilities insufficient but that doesn't seem to be the case when run from cargo wasi test. I'll spare you the stack trace.
Lucky for me, the issue referenced above showed how to make it work with a proper command line:
CARGO_TARGET_WASM32_WASI_RUNNER="wasmtime --dir=." cargo wasi test
Not to hijack this, but still looking for how to allow the capability for read-only.
I'm going to archive this repository (some more notes in https://github.com/bytecodealliance/cargo-wasi/issues/143) so I'm going through and cleaning up the old PRs and issues and closing them. Not much activity has happened on this repository in quite some time so I figured now's a good a time as any to "officially" close this repository and have it archived.