StarlingMonkey icon indicating copy to clipboard operation
StarlingMonkey copied to clipboard

Intl support

Open kyleconroy opened this issue 1 year ago • 9 comments

How difficult would it be to add support for the Intl namespace object?

kyleconroy avatar May 09 '24 17:05 kyleconroy

We are currently hitting this LLVM issue on this build - https://github.com/llvm/llvm-project/issues/100084.

guybedford avatar Aug 27 '24 18:08 guybedford

@guybedford looks like there is a resolution of the LLVM issue?

kyleconroy avatar Jan 24 '25 19:01 kyleconroy

Yes, that issue is resolved, so that this is now blocked on the Spidermonkey upgrade path for StarlingMonkey.

guybedford avatar Jan 24 '25 19:01 guybedford

Yikes, that sounds scary. Is there currently a plan for that?

kyleconroy avatar Jan 24 '25 19:01 kyleconroy

It will come, but there are no immediate plans unfortunately.

guybedford avatar Jan 24 '25 19:01 guybedford

that this is now blocked on the Spidermonkey upgrade path for StarlingMonkey

Is this about moving away from forked SpiderMonkey and inlining the streams implementation in StarlingMonkey?

andreiltd avatar Jan 24 '25 19:01 andreiltd

This is rebasing to the latest Spidermonkey, see the previous rebase PR at https://github.com/bytecodealliance/gecko-dev/pull/50 (the PBL changes have since landed upstream).

guybedford avatar Jan 24 '25 19:01 guybedford

(the PBL changes have since landed upstream).

Well, most of them -- I have to get to the last part of the weval-specific patches and submit them upstream if we don't want to drop weval support or rebase it carefully. Unfortunately I'm needing to prioritize other work at the moment and there's no clear timeline for me to get to this (perhaps in the latter half of 2025).

cfallin avatar Jan 24 '25 21:01 cfallin

A bit of an update: I was able to spend a today today working on isolating and putting together a patch for the last bits of weval support to upstream (current version on work-in-progress branch here). It is hitting some errors during wevaling and while I had a day to work on this, I don't have unlimited time to debug at the moment, so I'll need to let it sit for a little bit more. Hopefully at some point I'll get another chunk of time and try to push this forward more.

cfallin avatar Feb 28 '25 01:02 cfallin