StarlingMonkey icon indicating copy to clipboard operation
StarlingMonkey copied to clipboard

Allow specifying dependencies from subprojects

Open lpereira opened this issue 1 year ago • 4 comments

This patch makes it possible for users of the add_builtins() CMake function to specify a per-builtin dependency on another target. This has been used to fix #42.

lpereira avatar May 07 '24 21:05 lpereira

I can confirm this resolves the issue for us.

guybedford avatar May 08 '24 01:05 guybedford

Force-pushed changes that:

  1. Remove LINK_LIBS
  2. Establish DEPENDENCIES as a more general-purpose way of declaring the dependencies of built-ins
  3. Installs OpenSSL in ${CMAKE_BINARY_DIR}/deps/OpenSSL, so it's clearer that it's a dependency
  4. Patches usages of LINK_LIBS in builtins.cmake to use DEPENDENCIES instead
  5. Uses a VERBOSE message when printing information about a builtin's dependencies

lpereira avatar May 08 '24 20:05 lpereira

Again I can confirm that the latest updates all work correctly in the Fastly branch.

guybedford avatar May 10 '24 17:05 guybedford

Rebased and force-pushed with the clarifications.

lpereira avatar May 21 '24 18:05 lpereira