rumqtt icon indicating copy to clipboard operation
rumqtt copied to clipboard

Add MQTT v5 connection session_expiry_interval support

Open xiaocq2001 opened this issue 9 months ago • 1 comments

Fixing issue https://github.com/bytebeamio/rumqtt/issues/853

Type of change

New feature (non-breaking change which adds functionality)

  • Added session_expiry_interval support for MQTT V5 connection,

Checklist:

  • [ ] Formatted with cargo fmt
  • [ ] Make an entry to CHANGELOG.md if it's relevant to the users of the library. If it's not relevant mention why.

xiaocq2001 avatar Apr 30 '24 03:04 xiaocq2001

Thanks for the PR! can you please also mention the changes in CHANGELOG as well?

Updated.

xiaocq2001 avatar May 06 '24 02:05 xiaocq2001

Pull Request Test Coverage Report for Build 9072384592

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 13 (0.0%) changed or added relevant lines in 1 file are covered.
  • 107 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.1%) to 36.497%

Changes Missing Coverage Covered Lines Changed/Added Lines %
rumqttc/src/v5/mod.rs 0 13 0.0%
<!-- Total: 0 13
Files with Coverage Reduction New Missed Lines %
rumqttd/src/segments/mod.rs 7 97.34%
rumqttc/src/state.rs 42 78.83%
rumqttc/src/v5/state.rs 58 67.56%
<!-- Total: 107
Totals Coverage Status
Change from base Build 8762117251: 0.1%
Covered Lines: 5983
Relevant Lines: 16393

💛 - Coveralls

coveralls avatar May 14 '24 11:05 coveralls

Moved the code to apply broker returned session_expiry_interval here, please check.

xiaocq2001 avatar May 16 '24 06:05 xiaocq2001