bytebase icon indicating copy to clipboard operation
bytebase copied to clipboard

helm chart version control

Open daviderli614 opened this issue 11 months ago • 7 comments

Is your feature request related to a problem?

The bytebase helm chart version is always 1.1.0. When new features are added in the chart, it is still this version. There is no way to helm upgrade?

helm search repo bytebase
NAME             	CHART VERSION	APP VERSION	DESCRIPTION
bytebase/bytebase	1.1.0        	           	Safe database schema change and version control...

Describe the solution you'd like

  1. Suggestion to add appVersion in the chart.yaml.
  2. Add chart version control, every chart version is a new feature.

Additional context

No response

daviderli614 avatar Mar 25 '24 15:03 daviderli614

The bytebase helm chart version is always 1.1.0.

We have other versions before, likes 1.0.0, but we deletes these versions because we deprecated some Bytebase images.

When new features are added in the chart, it is still this version.

Oops, it seems like we forget to bump the Helm version while we add support for resource control via #11094.

Suggestion to add appVersion in the chart.yaml

We will look into this, thanks!

h3n4l avatar Mar 26 '24 02:03 h3n4l

Thanks for your answer, how to bump the Helm version? Maybe change this Chart.yaml.

We use argocd to dependencies a version of Helm. If the version is deprecated, there may be a dependencies failure?

daviderli614 avatar Mar 26 '24 03:03 daviderli614

how to bump the Helm version? Maybe change this Chart.yaml.

Yes, but we do not bump the helm (package?) version while we release new version of Bytebase, unless we adjust the chart to support new features or new options. Otherwise, we just upgrade the bytebase version value in the chart.

If the version is deprecated, there may be a dependencies failure?

Maybe. I am not familiar with argocd, but the deprecate operation is very rare and should not be a concern. We delete the old charts because of they reference the deprecated Bytebase images. Otherwise, we would receive numerous artifact hub alert emails which say "Cannot find image."

h3n4l avatar Mar 26 '24 03:03 h3n4l

Is it a good practice to bump the helm package version if we modify the default value in values.yaml?

h3n4l avatar Mar 26 '24 03:03 h3n4l

Is it a good practice to bump the helm package version if we modify the default value in values.yaml?

Maybe every change is a new chart version.

daviderli614 avatar Mar 26 '24 04:03 daviderli614

There are example, like kube-prometheus-stack and grafana, have a helm-chart repository, contains many versions of charts. usage document.

image image

daviderli614 avatar Mar 26 '24 14:03 daviderli614

The bytebase helm chart version is always 1.1.0.

We have other versions before, likes 1.0.0, but we deletes these versions because we deprecated some Bytebase images.

When new features are added in the chart, it is still this version.

Oops, it seems like we forget to bump the Helm version while we add support for resource control via #11094.

Suggestion to add appVersion in the chart.yaml

We will look into this, thanks!

appVersion is usually the bytebase docker image version.

daviderli614 avatar Mar 26 '24 14:03 daviderli614