egg icon indicating copy to clipboard operation
egg copied to clipboard

edmacro-subseq removed

Open SoftwareMaven opened this issue 10 years ago • 3 comments

On July 11, 2013, edmacro-subseq was removed, breaking the ability to view diffs in the status buffer. According to the commit log, edmacro-subseq is a re-implementation of cl-lib's cl-subseq.

SoftwareMaven avatar Mar 26 '14 18:03 SoftwareMaven

Thank you for your information. I'll fix it.

byplayer avatar Mar 28 '14 01:03 byplayer

For fun, I added the following, which allows the code to continue working. Switching to the cl version is probably the right thing, based on the direction the Emacs core is going. Would you take a pull request with such a change? Or would you prefer a stand-along re-implementation of subseq? Let me know which you prefer and I send a PR in.

(defun edmacro-subseq
    (seq start &optional end)
  (require 'cl)
  (if end
      (cl-subseq seq start end)
    (cl-subseq seq start)))

This implementation at least limits loading cl to when it is actually used. :)

SoftwareMaven avatar Oct 02 '14 18:10 SoftwareMaven

Thank you for your comment.

Could you send me pull request?

byplayer avatar Oct 04 '14 05:10 byplayer