connect4 icon indicating copy to clipboard operation
connect4 copied to clipboard

Published 20 hours ago • verified publisher icon bymayanksingh

Support for different board sizes + coin drop animation

Open amanpalariya opened this issue 5 years ago • 5 comments

I'm confused

amanpalariya avatar Dec 16 '19 04:12 amanpalariya

@amanpalariya don't be confused, you have done exactly what I asked you to do.

bymayanksingh avatar Dec 17 '19 01:12 bymayanksingh

we have some conflicts here.. please remove them.. also I am very happy with your coin drop animation.. can you keep only keep these changes

  • coin drop animation
  • generalizations
  • ability to change aesthetics

I am a bit reluctant to merge other changes such as:

  1. reduced font size.
  2. increased section height.

What I will suggest is don't do anything with this section, keep it as it is !

Screenshot from 2019-12-17 07-52-28

bymayanksingh avatar Dec 17 '19 02:12 bymayanksingh

Done 👍🏻

amanpalariya avatar Dec 18 '19 04:12 amanpalariya

If this PR is merged, people working on issue #7 will have to change the code a little because the board is drawn with coloured rectangle + black circle in their branch and I have done it using transparent tileable pattern board1_100px.png. Coin drop animation will not work without a transparent board.

amanpalariya avatar Dec 18 '19 04:12 amanpalariya

thanks for the amazing job done @amanpalariya I will see what I can do while merging in your PR as we have 2 other open PRs for issue 7

bymayanksingh avatar Jan 02 '20 14:01 bymayanksingh