bye43

Results 161 comments of bye43

Description | Value -- | -- Subgraph Reviewed | https://subgraphs.messari.io/subgraph?endpoint=https://api.thegraph.com/subgraphs/name/messari/makerdao-ethereum&tab=pool&poolId=0x2f0b23f53734252bda2277357e97e1517d6b042a Date Reviewed | August 19 2022 Schema Version | 1.3.0 Subgraph Version | 1.1.1 Methodology Version | 1.1.0 Evidence Spreadsheet...

@tnkrxyz Not going to raise a formal issue since a lot of comments might not result in changes to the subgraph. Couple things I have questions about, so just going...

@tnkrxyz and I discussed `dailyLquidateUSD` and have decided that the current implementation is correct. I am going to leave some of the notes @tnkrxyz made in discord, as I think...

@this-username-is-taken this can be frozen! @tnkrxyz thanks for all the hard work.

Awesome! Thanks @jaimehgb. Will take a look again when the subgraph is resynced.

> FYI It's been syncing for a couple of days now, it's on `2021-09-28`. > > Feel free to take a look at it already, or wait until it gets...

@jaimehgb Looks like all the cumulative revenues and the dailyVolumeByTokenUSD - USDC metrics look good now. The other metrics (stakedOutputTokenAmount, rewardTokenEmissionsAmount, rewardTokenEmissionsUSD) also look like they are outputting values now,...

@jaimehgb I think from my last quick check the core metrics should be fine in the default version, so I think it makes the most sense to wait and check...

@this-username-is-taken I think this has indexed to 02/2022, so was going to try to QA it by the EOW. Can hold off though if you think it needs to index...

@this-username-is-taken @jaimehgb The non-reward metrics look good here, so I think this can be frozen for Mainnet if we are going to add in reward tokens later. Just for tracking...