faker icon indicating copy to clipboard operation
faker copied to clipboard

Fix CI lint

Open soranoba opened this issue 2 years ago • 1 comments

phone.go:70:47: SA4030: (*math/rand.Rand).Intn(n) generates a random value 0 <= x < n; that is, the generated values don't include n; rand.Intn(1) therefore always returns 0 (staticcheck)
	return fmt.Sprintf("(%s) %s", boxDigitsStart[rand.Intn(1)], out)
	                                             ^
phone.go:94:45: SA4030: (*math/rand.Rand).Intn(n) generates a random value 0 <= x < n; that is, the generated values don't include n; rand.Intn(1) therefore always returns 0 (staticcheck)
	return fmt.Sprintf("+%s%s", boxDigitsStart[rand.Intn(1)], strings.Join(slice.IntToString(ints), ""))
	                                           ^
lorem.go:100:16: SA1019: strings.Title has been deprecated since Go 1.18 and an alternative has been available since Go 1.0: The rule Title uses for word boundaries does not handle Unicode punctuation properly. Use golang.org/x/text/cases instead. (staticcheck)
			sentence += strings.Title(wordList[val])
			            ^

soranoba avatar Jul 28 '22 07:07 soranoba

Hi @soranoba

Can you re-fixing this again, I just fixing some linter issue in #167

bxcodec avatar Aug 11 '22 15:08 bxcodec

@bxcodec Thank you. I did it.

soranoba avatar Aug 12 '22 03:08 soranoba

Thanks @soranoba merged

bxcodec avatar Aug 13 '22 02:08 bxcodec