Iman Tumorang comments

Results 76 comments of


                                            Iman Tumorang

Performance issue when generating 10k elements in array

Interesting. Will need a focus weekend to work on this. I'll pick up and investigate whenever I'm free. But if you have the fixes, please help raise the PR whenever...

About interface{} type suggestion

I'm closing this. Any PR is welcome. We appreciate the idea, but show me the code :)

Adding nested tags for slice of strings

Hi @HARDY8118 Thanks for the idea. I don't see any harm having the nested (yet). Maybe can you add more usecases/tests? Worried if we add this, then people will expecting...

Adding nested tags for slice of strings

@rubemlrm any opinion from your side?

Custom Tag Name

Left a comment in the PR

concurrent map writes happened while use "options.WithGenerateUniqueValues(true)"

Can you give me your test scenario? How to reproduce it here? What are the usecases?

concurrent map writes happened while use "options.WithGenerateUniqueValues(true)"

``` uniqueValues[dataType] = append(uniqueValues[dataType], value) ``` This line definitely not safe for concurrent

concurrent map writes happened while use "options.WithGenerateUniqueValues(true)"

Hi @Milk-Tang and @ornj Thanks for the issue, and I'm sorry for the late update. Can you try v4.4.2, it should be fixed.

CustomProvider only supports tagged fields

This is expected. The custom providers only support tagged fields. We can't check based on struct's property yet.

CustomProvider only supports tagged fields

What do you mean? is it something like you mention above? Or do you have any some usecase?