Bartlomiej Plotka
Bartlomiej Plotka
Definitely. Help wanted to improve it on v2 branch.
Yes, before tagging major version v2 we have to work on commits. Thank you @olivierlemasle for explaining all well 👍🏽 Let's keep this issue open until this works. Changed title...
I believe tags are crucial to generate request/operation ID, no? Also we used tags to pass info between middlewares (across network even!). 🤔 We definitely did not use this feature...
If we simplify tags to just passing stuff no extraction from types - I think we could have them in v2 or after (:
What about passing it through? Kind Regards, Bartek Płotka (@bwplotka) On Mon, 18 Jan 2021 at 19:52, Johan Brandhorst-Satzkorn < [email protected]> wrote: > In my experience you can defer "requestID"...
As talked offline, agree. Removing field extraction. Still torn on tags passing between middleware that only works if Tags interceptor is enabled. It's super confusing. I think I will kill...
I can see there are literally two context states: `niceMD` and `tags` niceMd are metadata trailers (`type MD map[string][]string`) passed between gRPC peers, tags are internal (`map[string]string`) I think it's...
I feel all of this should be part of tracing... But then it makes logging weird as it would use tracing parts 🤔
It can yes... but not sure what we want to have on our middleware then. Kind of sucks to reimplement context logger
Sorry for lag! Yes, while this is great, we have opportunity to change things on `v2` - we would love to not add new features to current v1 (master)