bingo icon indicating copy to clipboard operation
bingo copied to clipboard

bingo get does not update {package}.mod go version

Open wiardvanrij opened this issue 2 years ago • 3 comments

bingo version output:

v0.5.2

go version output:

go version go1.18 darwin/arm64

What happened:

I'm running with bingo get github.com/plexsystems/[email protected]

which looks like:

module _ // Auto generated by https://github.com/bwplotka/bingo. DO NOT EDIT

go 1.15

require github.com/plexsystems/promdoc v0.7.0

Then I did the update with: bingo get github.com/plexsystems/[email protected]

and I got:

module _ // Auto generated by https://github.com/bwplotka/bingo. DO NOT EDIT

go 1.15

require github.com/plexsystems/promdoc v0.8.0

What you expected to happen:

Getting:

module _ // Auto generated by https://github.com/bwplotka/bingo. DO NOT EDIT

go 1.18

require github.com/plexsystems/promdoc v0.8.0

How to reproduce it (as minimally and precisely as possible):

already described

Logs (use bingo get -v <thing you do> for verbose output):

Anything else we need to know:

I fixed this by removing {package}.mod (in this case promdoc.mod and then run the get on v.0.8.0

wiardvanrij avatar May 09 '22 15:05 wiardvanrij

Hey, thanks for reporting.

I assume you mean it does not work because the go statement is still 1.15?

Yea, we don't change go statement version for compatibility. In practice this is never needed, unless you want to use potentially new commands in .mod file which bingo does not sue. Why you want that go version to be improved?

bwplotka avatar May 09 '22 16:05 bwplotka

Well I just noticed it because I first checked the package on github and saw that they changed their mod file. I think it's "weird" or if anything, a little bit confusing to not exactly use the 'upstream' mod file. If you have a clean setup and use the bingo get we do get the exact version. So that does not make it consistent.

I personally don't have a strong opinion about how it should work.

wiardvanrij avatar May 09 '22 16:05 wiardvanrij

Just to be strict, exeat version of go? Because that is simply version of Go module format nothing else (:

bwplotka avatar Jun 02 '22 07:06 bwplotka