irlba icon indicating copy to clipboard operation
irlba copied to clipboard

irlba's implementation of prcomp loses rotation rownames

Open leahrosen opened this issue 3 years ago • 1 comments

Hi, I've rewritten my code to replace prcomp with prcomp_irlba (so much faster 🙌 ), and got an error because, downstream, I call rownames of the rotation matrix, however in irlba's implementation, the rotation matrix has lost the rownames. It would be very useful if you could add back the rownames, to allow more seamless conversion between prcomp and irlba.

leahrosen avatar Apr 29 '21 09:04 leahrosen

Thanks for this suggestion, will put this on the todo list for the next update.

On 4/29/21, leahrosen @.***> wrote:

Hi, I've rewritten my code to replace prcomp with prcomp_irlba (so much faster 🙌 ), and got an error because, downstream, I call rownames of the rotation matrix, however in irlba's implementation, the rotation matrix has lost the rownames. It would be very useful if you could add back the rownames, to allow more seamless conversion between prcomp and irlba.

--

You are receiving this because you are subscribed to this thread.

Reply to this email directly or view it on GitHub:

https://github.com/bwlewis/irlba/issues/59

bwlewis avatar Apr 30 '21 17:04 bwlewis